Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing query param multi-value type definition #77

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Add missing query param multi-value type definition #77

merged 1 commit into from
Mar 26, 2020

Conversation

juriwiens
Copy link
Contributor

@juriwiens juriwiens commented Mar 26, 2020 •
edited
Loading

The implementation allows to provide multiple query param values for the same key like: query: { fields: ["a", "b"] }. This PR adds the corresponding type definitions to stay in sync with the implementation.

Checklist

  • run npm run test and npm run benchmark
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message and code follows Code of conduct

@juriwiens
Add missing query param multi-value type definition
37d6ac0 
To stay in sync with the implementation.
@juriwiens juriwiens mentioned this pull request Mar 26, 2020
Closed
mcollina
mcollina approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eomm Eomm merged commit 7f003d8 into fastify:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eomm Eomm Eomm approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juriwiens @mcollina @Eomm